fix worker not releasing limit slot on failed propose pending state #16012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdjfisher
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #16012 will not alter performanceComparing Summary
|
|
Thanks for the PR @jdjfisher! I think there's one other place where your new For a test, I think you could write a test similar to this one: prefect/tests/workers/test_base_worker.py Line 341 in 86b80dc _propose_pending_state to return False so that you can ensure that the concurrency limiter slot is correctly released.
Let me know if you have any questions about either of those points! |
jdjfisher
force-pushed
the
fix-worker-limiter-release-15952
branch
from
d2be850
to
75d87f4
Compare
|
Thanks for the review @desertaxle, super helpful. I'm managed to put a case together based on your suggestions that should cover this fix. |
desertaxle
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where workers aborting a flow run submission doesn't release the concurrency slot that was claimed. I've based this on what has been done in the runner as this issue doesn't seem to exist over there
prefect/src/prefect/runner/runner.py
Line 963 in 8758666
Closes #15952